Skip to content

Fix suggestion for E0404 not dealing with multiple generics #112486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix suggestion for E0404 not dealing with multiple generics #112486

merged 1 commit into from
Jun 15, 2023

Conversation

jieyouxu
Copy link
Member

Fixes #112472.

@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 10, 2023
@jieyouxu
Copy link
Member Author

Note that it might be possible to detect in "{}: {}<{} = {}>" if the second part ends with a > bracket and then replace that with , , but I'm not too sure about the correctness of that approach. The current approach constructs a new WhereBoundPredicate AST node and pretty prints it (to hopefully avoid strange syntax error edge cases).

oli-obk
oli-obk reviewed Jun 15, 2023
View reviewed changes
oli-obk
oli-obk reviewed Jun 15, 2023
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Jun 15, 2023

Not sure if my ideas make sense, lmk of any opinions you have on them

@oli-obk
Copy link
Contributor

oli-obk commented Jun 15, 2023

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Jun 15, 2023

📌 Commit 32ae881 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 15, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2023
@bors
Auto merge of rust-lang#112661 - matthiaskrgr:rollup-9u5i2zy, r=matth…
331249a 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#111212 (Add casting suggestion when assigning negative 2's complement bin or hex literal to a size compatible signed integer)
 - rust-lang#112304 (Add chapter in rustdoc book for re-exports and add a regression test for `#[doc(hidden)]` behaviour)
 - rust-lang#112486 (Fix suggestion for E0404 not dealing with multiple generics)
 - rust-lang#112562 (rustdoc-gui: allow running on Windows)
 - rust-lang#112621 (Mention `env!` in `option_env!`'s docs)
 - rust-lang#112634 (add InlineConst check)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 82eb4a0 into rust-lang:master Jun 15, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 15, 2023
@jieyouxu jieyouxu deleted the issue-112472 branch October 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

suggestion for handling E0404 doesn't deal with multiple generics properly
4 participants
@jieyouxu @rustbot @oli-obk @bors